Francesco Romani has posted comments on this change. Change subject: Implementation for CPU topology reporting ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/23268/5/ovirt-guest-agent/topology.py File ovirt-guest-agent/topology.py: Line 100: result['details'] = details Line 101: return result Line 102: Line 103: Line 104: if __name__ == '__main__': > Code seems ok but I'd add a couple of unit test, even just for reference an Sorry, forgot to add. It is unlikely the format of linux files ever changes, so the purpose of the tests will be reference and docs. Line 105: from pprint import pprint Line 106: print 'Topology:' Line 107: pprint(read_topology()) Line 108: print 'Topology detailed:' -- To view, visit http://gerrit.ovirt.org/23268 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If937fd33d2efa11425c814188df2087a85af8357 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
