Michal Skrivanek has posted comments on this change. Change subject: Implementation for CPU topology reporting ......................................................................
Patch Set 5: (1 comment) I'd reconsider the 3600s refresh time. App list is 120 and is much heavier on the system. http://gerrit.ovirt.org/#/c/23268/5/ovirt-guest-agent/topology.py File ovirt-guest-agent/topology.py: Line 66: return _read_file('online') Line 67: Line 68: Line 69: def _online_list(): Line 70: return _read_range_file_to_list('online') > As matter of personal taste I don't know if the 5 one-liners [_present_rang +1 Line 71: Line 72: Line 73: def read_topology(detailed=False): Line 74: cores = set() -- To view, visit http://gerrit.ovirt.org/23268 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If937fd33d2efa11425c814188df2087a85af8357 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
