Maor Lipchuk has posted comments on this change. Change subject: core,webadmin: Move storage type checks to domain instead of pool ......................................................................
Patch Set 1: Code-Review-1 (2 comments) You did not responded to any of my comments at http://gerrit.ovirt.org/#/c/23072/4 http://gerrit.ovirt.org/#/c/23294/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDiskAlignmentCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDiskAlignmentCommand.java: Line 115: Line 116: StorageDomainStatic sds = getStorageDomainStaticDAO().get(((DiskImage)getDisk()).getStorageIds().get(0)); Line 117: if (!sds.getStorageType().isBlockDomain()) { Line 118: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_ALIGNMENT_SCAN_STORAGE_TYPE); Line 119: } You did not respond to my last comment here at http://gerrit.ovirt.org/#/c/23072/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDiskAlignmentCommand.java Line 120: } Line 121: Line 122: if (isImageExclusiveLockNeeded() && getVm().isRunningOrPaused()) { Line 123: return failCanDoAction(VdcBllMessages.ERROR_CANNOT_RUN_ALIGNMENT_SCAN_VM_IS_RUNNING); http://gerrit.ovirt.org/#/c/23294/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java: Line 379: * Returns whether to use Sparse or Preallocation. If the storage type is file system devices ,it would be more Line 380: * efficient to use Sparse allocation. Otherwise for block devices we should use Preallocated for faster allocation. Line 381: * Line 382: * @return - VolumeType of allocation type to use. Line 383: */ See my last comment http://gerrit.ovirt.org/#/c/23072/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java Line 384: public static VolumeType getMemoryVolumeTypeForPool(StorageType storageType) { Line 385: return storageType.isFileDomain() ? VolumeType.Sparse : VolumeType.Preallocated; Line 386: } Line 387: -- To view, visit http://gerrit.ovirt.org/23294 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3db80f1749d93444e9cdac8038859b7d0865f6e5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
