Ayal Baron has posted comments on this change. Change subject: core,webadmin: Move storage type checks to domain instead of pool ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/23294/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/LiveSnapshotMemoryImageBuilder.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/LiveSnapshotMemoryImageBuilder.java: Line 31: private VM vm; Line 32: private TaskHandlerCommand<?> enclosingCommand; Line 33: private StoragePool storagePool; Line 34: Line 35: public LiveSnapshotMemoryImageBuilder(VM vm, StorageDomain storageDomain, > It is actually, I moved from transferring the domain id as the parameter to again, this is an optimization that albeit welcome, is unrelated to the change here and needs to be separate. any change has risk and doing it in the same patch means that if one has a problem then the other would have to be reverted as well. Line 36: StoragePool storagePool, TaskHandlerCommand<?> enclosingCommand) { Line 37: this.vm = vm; Line 38: this.enclosingCommand = enclosingCommand; Line 39: this.storageDomain = storageDomain; -- To view, visit http://gerrit.ovirt.org/23294 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3db80f1749d93444e9cdac8038859b7d0865f6e5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
