Alon Bar-Lev has posted comments on this change. Change subject: Change versioning schema and fix tarball ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/22874/8/configure.ac File configure.ac: Line 16: AC_SUBST([PACKAGE_RPM_VERSION]) Line 17: AC_SUBST([PACKAGE_RPM_RELEASE]) Line 18: Line 19: AC_CONFIG_AUX_DIR([.]) Line 20: AC_CONFIG_MACRO_DIR([m4]) > Why are we setting this without providing macros in m4? usually m4 is required for either libtool or gettext. however, as this package does not use both it can be removed from here and from Makefile.am. But it does not have any negative impact. Line 21: AC_USE_SYSTEM_EXTENSIONS Line 22: AM_INIT_AUTOMAKE Line 23: Line 24: # Automake initialization -- To view, visit http://gerrit.ovirt.org/22874 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4337150f58cd7d9b3a04a12a3afa9acd8a826a22 Gerrit-PatchSet: 8 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
