Adam Litke has posted comments on this change. Change subject: Change versioning schema and fix tarball ......................................................................
Patch Set 12: Code-Review-1 (4 comments) Just a few more small issues left http://gerrit.ovirt.org/#/c/22874/12/configure.ac File configure.ac: Line 9: define([VERSION_SUFFIX], [_master]) Line 10: Line 11: AC_INIT([mom], VERSION_NUMBER[]VERSION_SUFFIX, [[email protected]]) Line 12: PACKAGE_RPM_VERSION="VERSION_NUMBER" Line 13: PACKAGE_RPM_RELEASE="4.$(echo VERSION_SUFFIX | sed 's/^_//')" Please address my previous comment where I suggested changing this to: PACKAGE_RPM_RELEASE="0$(echo VERSION_SUFFIX | sed 's/^_/./')" Line 14: PACKAGE_NAME="mom" Line 15: AC_SUBST([PACKAGE_NAME]) Line 16: AC_SUBST([PACKAGE_RPM_VERSION]) Line 17: AC_SUBST([PACKAGE_RPM_RELEASE]) http://gerrit.ovirt.org/#/c/22874/12/mom.spec.in File mom.spec.in: Line 51: %prep Line 52: %setup -q -n %{package_name}-%{package_version} Line 53: Line 54: %build Line 55: %configure From Alon, %configure --docdir="%{_pkgdocdir}" here, then we can get rid of the complex moving around of documentation below. Line 56: make %{?_smp_mflags} Line 57: Line 58: %install Line 59: rm -rf "%{buildroot}" Line 66: # be installed in a versioned or unversioned directory and thus it Line 67: # always installs them into an unversioned directory. Move it in two Line 68: # stages to avoid errors when we are already using an unversioned dir. Line 69: mv "%{buildroot}"/%{_defaultdocdir}/%{package_name} "%{buildroot}"/_tmp Line 70: mv "%{buildroot}"/_tmp "%{buildroot}"/%{_pkgdocdir} The above 2 lines and associated comment can be removed with the configure change above. Line 71: cp -p COPYING README "%{buildroot}"/%{_pkgdocdir} Line 72: Line 73: %check Line 74: make check %{?_smp_mflags} Line 95: Line 96: Line 97: %files Line 98: %defattr(-,root,root,-) Line 99: %{_pkgdocdir}/ We can remove this and go back to %doc for COPYING and README. I guess you will have to experiment how to get the $(_docdir)/examples files into the files section. Line 100: %{_sbindir}/momd Line 101: %{_initrddir}/momd Line 102: %{python_sitelib}/* Line 103: %config(noreplace) %{_sysconfdir}/momd.conf -- To view, visit http://gerrit.ovirt.org/22874 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4337150f58cd7d9b3a04a12a3afa9acd8a826a22 Gerrit-PatchSet: 12 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
