Einav Cohen has posted comments on this change. Change subject: [WIP] webadmin: Change LoginPopup to present clickable password URL change ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/23373/1/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/login/view/LoginPopupView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/login/view/LoginPopupView.java: Line 168: int urlIndex = text.indexOf(("http://";));//$NON-NLS-1$ Line 169: String beforeURL = text.substring(0, urlIndex); Line 170: String url = text.substring(urlIndex); Line 171: StringBuilder htmlPart = new StringBuilder(); Line 172: htmlPart.append(beforeURL).append("<a href=\"").append(url).append("\">").append(url).append("</a>"); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ maybe add: target="_blank" to the "a" tag, to make sure that password changing window (or any other window, for that matter) will not "override" the existing ovirt GUI window, but will open in a new browser tab/window? Line 173: errorMessage.getElement().setInnerHTML(htmlPart.toString()); Line 174: } else { Line 175: errorMessage.setText(text); Line 176: } -- To view, visit http://gerrit.ovirt.org/23373 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I502cfcad23c3500f1e87e3f45657cf61e9c36d69 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
