Yair Zaslavsky has posted comments on this change. Change subject: webadmin: Change LoginPopup to present clickable password URL change ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/23373/3/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/AbstractLoginPopupView.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/AbstractLoginPopupView.java: Line 115: if (text != null && text.contains("http")) { //$NON-NLS-1$ Line 116: int urlIndex = text.indexOf(("http"));//$NON-NLS-1$ Line 117: String beforeURL = text.substring(0, urlIndex); Line 118: String url = text.substring(urlIndex); Line 119: StringBuilder htmlPart = new StringBuilder(); > s/test/text Yes, This it the way the BLL message is constructed. Line 120: htmlPart.append(beforeURL) Line 121: .append("<a href=\"").append(url).append("\" target=\"_blank\">").append(url).append("</a>"); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ Line 122: errorMessageLabel.getElement().setInnerHTML(htmlPart.toString()); Line 123: } else { -- To view, visit http://gerrit.ovirt.org/23373 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I502cfcad23c3500f1e87e3f45657cf61e9c36d69 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
