Michael Pasternak has posted comments on this change.
Change subject: restapi : Allowing to pass directLun disks
......................................................................
Patch Set 1: (5 inline comments)
....................................................
File
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskMapper.java
Line 56
why this propes where removed?
Line 75
why removing return?, it's true that mapping can be done byref, but pls. keep it
Line 79
where is:
public static Disk map(DiskImage entity, Disk template) {
sig?
Line 104
same here
Line 118
same here
--
To view, visit http://gerrit.ovirt.org/4199
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ac7300ee625c8a2185bedb092702e6503e380b3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
