Michael Kublin has posted comments on this change.

Change subject: restapi : Allowing to pass directLun disks
......................................................................


Patch Set 1: (5 inline comments)

....................................................
File 
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskMapper.java
Line 56
I make a method where the property is set, please look at line 42 at the right

Line 75
there are still return , the comparison is not correct, please take a look to 
the line 60, at right

Line 79
no need anymore, the rest usually will get form engine Disk class, it is an 
abstract class which should represent all disks at the system

Line 104
line 110

Line 118
line 119

--
To view, visit http://gerrit.ovirt.org/4199
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5ac7300ee625c8a2185bedb092702e6503e380b3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to