Tal Nisan has posted comments on this change. Change subject: core,webadmin: Remove of storage pool type ......................................................................
Patch Set 3: (4 comments) http://gerrit.ovirt.org/#/c/23402/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StoragePoolValidator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StoragePoolValidator.java: Line 27: * In case there is mismatch, a proper canDoAction message will be added Line 28: * Line 29: * @return The result of the validation Line 30: */ Line 31: public ValidationResult isPosixSupportedDC() { > isPosixSupported*In*DC Done Line 32: if (!storagePool.isLocal() && Line 33: !Config.<Boolean> getValue(ConfigValues.PosixStorageEnabled, storagePool.getcompatibility_version().toString())) { Line 34: return new ValidationResult(VdcBllMessages.DATA_CENTER_POSIX_STORAGE_NOT_SUPPORTED_IN_CURRENT_VERSION); Line 35: } Line 41: * In case there is mismatch, a proper canDoAction message will be added Line 42: * Line 43: * @return true if the version matches Line 44: */ Line 45: public ValidationResult isGlusterSupportedDC() { > same Done Line 46: if (!storagePool.isLocal() && Line 47: !Config.<Boolean> getValue(ConfigValues.GlusterFsStorageEnabled, storagePool.getcompatibility_version().toString())) { Line 48: return new ValidationResult(VdcBllMessages.DATA_CENTER_GLUSTER_STORAGE_NOT_SUPPORTED_IN_CURRENT_VERSION); Line 49: } http://gerrit.ovirt.org/#/c/23402/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java: Line 95: if (oldSpVersion.equals(spVersion)) { Line 96: return; Line 97: } Line 98: Line 99: StorageType spType = storagePool.getStorageType(); > shouldn't have this line been replaced? Yes, absolutely, git add -p added this hunk along with another one to the other patch, good catch Line 100: final StorageFormatType targetFormat = VersionStorageFormatUtil.getPreferredForVersion(spVersion, spType); Line 101: Line 102: storagePool.setStoragePoolFormatType(targetFormat); Line 103: http://gerrit.ovirt.org/#/c/23402/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java: Line 3066: if (isLocalType) { Line 3067: return version.compareTo(new Version(3, 0)) >= 0; Line 3068: } Line 3069: else { Line 3070: return version.compareTo(new Version(3, 0)) >= 0; > I still don't see why we need the 'if..else' here? both cases are the same I left it like this for ease of maintenance basically, but will remove Line 3071: } Line 3072: } Line 3073: Line 3074: public static int getClusterDefaultMemoryOverCommit() { -- To view, visit http://gerrit.ovirt.org/23402 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If29a4ecb9aa284b57e9f5218ca50cf4287452e3e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
