Daniel Erez has posted comments on this change. Change subject: core,webadmin: Remove of storage pool type ......................................................................
Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/23402/4/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java: Line 623: List<StorageDomain> storages = (List<StorageDomain>) ((VdcQueryReturnValue) ReturnValue).getReturnValue(); Line 624: Line 625: StorageDomain storage = null; Line 626: for (StorageDomain sd : storages) { Line 627: if (sd.getStorageDomainType() == StorageDomainType.Master || use 'isDataDomain()' Line 628: sd.getStorageDomainType() == StorageDomainType.Data) { Line 629: storage = sd; Line 630: } Line 631: } http://gerrit.ovirt.org/#/c/23402/4/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java: Line 572: && (isMoveCommandAvailable() || isLiveMoveCommandAvailable())); Line 573: Line 574: updateGetAlignmentCommandAvailability(); Line 575: Line 576: updateScanAlignmentEnabled(); we avoid executing queries on 'updateActionAvailability' as it being called every few seconds. Either get the storage types of disk beforehand (e.g. on syncSearch), or, cache the data of 'updateScanAlignmentEnabled' so it won't be queried every few seconds. Line 577: Line 578: getPlugCommand().setIsExecutionAllowed(isPlugCommandAvailable(true)); Line 579: Line 580: getUnPlugCommand().setIsExecutionAllowed(isPlugCommandAvailable(false)); -- To view, visit http://gerrit.ovirt.org/23402 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If29a4ecb9aa284b57e9f5218ca50cf4287452e3e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
