Tal Nisan has posted comments on this change. Change subject: core,webadmin: Move storage type checks to domain instead of pool ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/23294/5/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java: Line 723: } Line 724: } Line 725: Line 726: private void storageDomain_SelectedItemChanged() { Line 727: StorageDomain selectedStorage = (StorageDomain) getStorageDomain().getSelectedItem(); > Actually could be fine - check what happens in GWT debug mode. If you don't have at least one storage domain to select the DC will not be up and you won't have it in the selection so iiuc there can't be an NPE Line 728: if (selectedStorage != null) { Line 729: updateVolumeType(selectedStorage.getStorageType()); Line 730: } Line 731: updateQuota((StoragePool) getDataCenter().getSelectedItem()); -- To view, visit http://gerrit.ovirt.org/23294 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3db80f1749d93444e9cdac8038859b7d0865f6e5 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
