Tal Nisan has posted comments on this change. Change subject: core,webadmin: Move storage type checks to domain instead of pool ......................................................................
Patch Set 2: (3 comments) http://gerrit.ovirt.org/#/c/23294/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java: Line 168: Line 169: setSucceeded(true); Line 170: } Line 171: Line 172: private StorageDomain getStorageDomainForVmMemory() { > The changes in this file are unrelated to the patch. Done Line 173: if (cachedStorageDomain == null && getVm() != null) { Line 174: long sizeNeeded = getVm().getTotalMemorySizeInBytes() / BYTES_IN_GB; Line 175: StorageDomain storageDomain = VmHandler.findStorageDomainForMemory(getVm().getStoragePoolId(), sizeNeeded); Line 176: if (storageDomain != null) { http://gerrit.ovirt.org/#/c/23294/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java: Line 340: params.setParentParameters(getParameters()); Line 341: Line 342: // if the data domains are block based storage, the memory volume type is preallocated Line 343: // so we need to use copy collapse in order to convert it to be sparsed in the export domain Line 344: if (getStorageDomain().getStorageType().isBlockDomain()) { > getStorageDomain is the TARGET domain - you should get the SOURCE domain ac In that case there was a bug before? Since it used the storage pool of the target domain iiuc. Done. Line 345: params.setUseCopyCollapse(true); Line 346: params.setVolumeType(VolumeType.Sparse); Line 347: params.setVolumeFormat(VolumeFormat.RAW); Line 348: } http://gerrit.ovirt.org/#/c/23294/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/LiveSnapshotMemoryImageBuilder.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/LiveSnapshotMemoryImageBuilder.java: Line 31: private VM vm; Line 32: private TaskHandlerCommand<?> enclosingCommand; Line 33: private StoragePool storagePool; Line 34: Line 35: public LiveSnapshotMemoryImageBuilder(VM vm, StorageDomain storageDomain, > again, this is an optimization that albeit welcome, is unrelated to the cha Done Line 36: StoragePool storagePool, TaskHandlerCommand<?> enclosingCommand) { Line 37: this.vm = vm; Line 38: this.enclosingCommand = enclosingCommand; Line 39: this.storageDomain = storageDomain; -- To view, visit http://gerrit.ovirt.org/23294 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3db80f1749d93444e9cdac8038859b7d0865f6e5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
