Yaniv Dary has posted comments on this change. Change subject: packaging: setup: remove the usage of rpm to check version ......................................................................
Patch Set 2: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/23419/2/packaging/legacy-setup/ovirt-engine-reports-setup.py File packaging/legacy-setup/ovirt-engine-reports-setup.py: Line 553: if len(currentjar) != 1: Line 554: raise RuntimeError('Cannot determine current jasper version') Line 555: currentjar = os.path.basename(currentjar[0]) Line 556: Line 557: return sourcejar == currentjar This is not a good way to test. Release changes in rpm by not in jars. On new release JRS needs to redeploy. Line 558: Line 559: @transactionDisplay("Exporting scheduled reports") Line 560: def exportScheduale(): Line 561: """ -- To view, visit http://gerrit.ovirt.org/23419 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8799bde82f7c2da2b0a3074ea47e6ffc3eb898cd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
