Yaniv Dary has posted comments on this change.

Change subject: packaging: setup: always deploy jasper war
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.ovirt.org/#/c/23419/3/packaging/legacy-setup/ovirt-engine-reports-setup.py
File packaging/legacy-setup/ovirt-engine-reports-setup.py:

Line 1162:                     if adminPass is None:
Line 1163:                         adminPass = getAdminPass()
Line 1164:                     # Execute js-ant to create DB and deploy WAR
Line 1165:                     # May also set DB_EXIST to False if WAR is in 
need of an upgrade
Line 1166:                     deployJs(db_dict, TEMP_PGPASS)
This should now run every time. You need to take it out of the if.
Line 1167: 
Line 1168:                 logging.debug("Database status: %s" % DB_EXIST)
Line 1169:                 # Update oVirt-Engine vdc_options with reports 
relative url
Line 1170:                 updateServletDbRecord(TEMP_PGPASS)


Line 1231:             except:
Line 1232:                 logging.error("Failed to complete the setup of the 
reports package!")
Line 1233:                 logging.debug(traceback.format_exc())
Line 1234:                 logging.debug("Restoring previous version")
Line 1235:                 if DB_EXIST:
should be isUpgrade
Line 1236:                     restoreWAR()
Line 1237:                     restoreDB(db_dict, TEMP_PGPASS)
Line 1238:                 raise
Line 1239: 


-- 
To view, visit http://gerrit.ovirt.org/23419
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8799bde82f7c2da2b0a3074ea47e6ffc3eb898cd
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Yaniv Dary <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to