Maor Lipchuk has posted comments on this change. Change subject: core: Changed master connection type in RecoveryStoragePool command ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/23344/4//COMMIT_MSG Commit Message: Line 7: core: Changed master connection type in RecoveryStoragePool command Line 8: Line 9: As a part of the effort to remove the type of storage pool changed Line 10: connection to new master in RecoveryStoragePool command to use the storage Line 11: helper of the type of new master. Until now the old master type was used Can you please make that sentence more clear, maybe extra comma is needed. I tried to read it three times but still didn't managed to understand what it means... "...storage pool changed connection to new master in RecoveryStoragePool command to use the storage helper of the type of new master" Will also be great to mention that you removed a validation. Line 12: since it didn't make any difference since the types of the old and new were Line 13: always the same Line 14: Line 15: Change-Id: Ifb0b0f98bdd239f201add78b08e8c1f86cf84757 -- To view, visit http://gerrit.ovirt.org/23344 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb0b0f98bdd239f201add78b08e8c1f86cf84757 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
