Tal Nisan has posted comments on this change. Change subject: core: Changed master connection type in RecoveryStoragePool command ......................................................................
Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/23344/4//COMMIT_MSG Commit Message: Line 7: core: Changed master connection type in RecoveryStoragePool command Line 8: Line 9: As a part of the effort to remove the type of storage pool changed Line 10: connection to new master in RecoveryStoragePool command to use the storage Line 11: helper of the type of new master. Until now the old master type was used > Can you please make that sentence more clear, maybe extra comma is needed. Done Line 12: since it didn't make any difference since the types of the old and new were Line 13: always the same Line 14: Line 15: Change-Id: Ifb0b0f98bdd239f201add78b08e8c1f86cf84757 http://gerrit.ovirt.org/#/c/23344/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RecoveryStoragePoolCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RecoveryStoragePoolCommand.java: Line 86: } Line 87: Line 88: @Override Line 89: protected void executeCommand() { Line 90: if (StorageHelperDirector.getInstance().getItem(getNewMaster(false).getStorageType()) > getNewMaster is being called also on the line below - can be exported to a It's a matter of style, I like it this was, especially when it's called with a parameter Line 91: .connectStorageToDomainByVdsId(getNewMaster(false), getVds().getId())) { Line 92: Line 93: ((EventQueue) EjbUtils.findBean(BeanType.EVENTQUEUE_MANAGER, BeanProxyType.LOCAL)).submitEventSync(new Event(getParameters().getStoragePoolId(), Line 94: _newMasterStorageDomainId, -- To view, visit http://gerrit.ovirt.org/23344 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb0b0f98bdd239f201add78b08e8c1f86cf84757 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
