Maor Lipchuk has posted comments on this change. Change subject: core: Change connect/disconnect storage commands to type agnostic ......................................................................
Patch Set 8: Code-Review-1 (3 comments) partial reviewed. You still didn't addressed some of my comments from http://gerrit.ovirt.org/#/c/23072/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePooServerCommandBase.java http://gerrit.ovirt.org/#/c/23296/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePoolServerCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePoolServerCommandBase.java: Line 61 Line 62 Line 63 Line 64 Line 65 as I asked before in patch http://gerrit.ovirt.org/#/c/23072/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePooServerCommandBase.java Can you please explain why was this have been removed? http://gerrit.ovirt.org/#/c/23296/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePoolServersCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePoolServersCommand.java: Line 44: Line 45: for (Map.Entry<StorageType, List<StorageServerConnections>> connectionToType : connectionsByType.entrySet()) { Line 46: StorageType connectionsType = connectionToType.getKey(); Line 47: List<StorageServerConnections> connections = connectionToType.getValue(); Line 48: connectSucceeded = connectSucceeded && connectStorageServersByType(connectionsType, connections); no point to stay in the for loop when the connect failed. You should simply print an error log and return false Line 49: } Line 50: Line 51: log.infoFormat("Host {0} storage connection was {1} ", getVds().getName(), connectSucceeded ? "succeeded" : "failed"); Line 52: Line 47: List<StorageServerConnections> connections = connectionToType.getValue(); Line 48: connectSucceeded = connectSucceeded && connectStorageServersByType(connectionsType, connections); Line 49: } Line 50: Line 51: log.infoFormat("Host {0} storage connection was {1} ", getVds().getName(), connectSucceeded ? "succeeded" : "failed"); You should indicate which storage type did not succeed. Line 52: Line 53: return connectSucceeded; Line 54: } Line 55: -- To view, visit http://gerrit.ovirt.org/23296 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I07a7fb8af9ce89a38b51cdb07a43a15f9c13f839 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
