Liron Ar has posted comments on this change. Change subject: core: Change connect/disconnect storage commands to type agnostic ......................................................................
Patch Set 10: (1 comment) http://gerrit.ovirt.org/#/c/23296/10/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePoolServerCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePoolServerCommandBase.java: Line 25: return connectionsTypeMap; Line 26: } Line 27: Line 28: protected void initConnectionList() { Line 29: _connections = DbFacade.getInstance().getStorageServerConnectionDao().getAllConnectableStorageSeverConnection(getStoragePool().getId()); now you'll perform connect operations also to domains in maintenance/locked statuses. opposed to the attempt in the previous version (line 114 base version) Line 30: updateConnectionsTypeMap(); Line 31: } Line 32: Line 33: private void updateConnectionsTypeMap() { -- To view, visit http://gerrit.ovirt.org/23296 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I07a7fb8af9ce89a38b51cdb07a43a15f9c13f839 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
