Alon Bar-Lev has posted comments on this change. Change subject: packaging: build: rewrite ......................................................................
Patch Set 14: (2 comments) kiril, done. did not run the actual package, but for the time being this is great improvement than what we had. http://gerrit.ovirt.org/#/c/22874/14/configure.ac File configure.ac: Line 35: AC_ARG_ENABLE( Line 36: [python-syntax-check], Line 37: [AS_HELP_STRING([--disable-python-syntax-check], [disable python syntax check @<:@default=enabled@:>@])], Line 38: , Line 39: [enable_python_syntax_check="no"] this is default no as this project does not confirm to pep8, please work out in separate patch to fix issues. Line 40: ) Line 41: Line 42: AC_PROG_INSTALL Line 43: Line 51: AC_CHECK_PROGS([PYFLAKES], [pyflakes]) Line 52: AC_ARG_VAR([PEP8], [path to pep8 utility]) Line 53: AC_CHECK_PROGS([PEP8], [pep8]) Line 54: Line 55: AX_PYTHON_MODULE([nose]) this is not fatal as it required only for ut, make dist and such should not fail if missing. Line 56: Line 57: AM_CONDITIONAL([PYTHON_SYNTAX_CHECK], [test "${enable_python_syntax_check}" = "yes"]) Line 58: Line 59: AC_CONFIG_FILES([ -- To view, visit http://gerrit.ovirt.org/22874 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4337150f58cd7d9b3a04a12a3afa9acd8a826a22 Gerrit-PatchSet: 14 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
