Adam Litke has posted comments on this change. Change subject: packaging: build: rewrite ......................................................................
Patch Set 14: (1 comment) http://gerrit.ovirt.org/#/c/22874/14/configure.ac File configure.ac: Line 22: define([VERSION_SUFFIX], [_master]) Line 23: Line 24: AC_INIT([mom], VERSION_NUMBER[]VERSION_SUFFIX, [[email protected]]) Line 25: PACKAGE_RPM_VERSION="VERSION_NUMBER" Line 26: PACKAGE_RPM_RELEASE="0.0.$(echo VERSION_SUFFIX | sed 's/^_//')" > in official release you modify this to 1, 2, 3 based on release. What is the 0.0 used for? So for a release I would have: PACKAGE_RPM_RELEASE=1 ? Line 27: AC_SUBST([PACKAGE_RPM_VERSION]) Line 28: AC_SUBST([PACKAGE_RPM_RELEASE]) Line 29: Line 30: AC_CONFIG_AUX_DIR([.]) -- To view, visit http://gerrit.ovirt.org/22874 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4337150f58cd7d9b3a04a12a3afa9acd8a826a22 Gerrit-PatchSet: 14 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
