Yedidyah Bar David has uploaded a new change for review. Change subject: core: dumpEnvironment str compare to old ......................................................................
core: dumpEnvironment str compare to old Without this change, dumpEnvironment does not log e.g. lists that some of their members changed, if the list object did not change. Change-Id: I15969681d8fab57e326a7977a5ed0703d4e9fbd7 Signed-off-by: Yedidyah Bar David <[email protected]> --- M src/otopi/context.py 1 file changed, 9 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/otopi refs/changes/17/23517/1 diff --git a/src/otopi/context.py b/src/otopi/context.py index e11e0cc..1cfa03f 100644 --- a/src/otopi/context.py +++ b/src/otopi/context.py @@ -381,6 +381,7 @@ def runSequence(self): """Run sequence.""" + oldEnvironmentStr = {} for self._currentStage in sorted(self._sequence.keys()): if_no_error = plugin.Stages.DATABASE[ self._currentStage @@ -403,10 +404,14 @@ not if_no_error or not self.environment[constants.BaseEnv.ERROR] ): - oldEnvironment = self.environment.copy() self._executeMethod(self._currentStage, methodinfo) - if oldEnvironment != self.environment: - self.dumpEnvironment(old=oldEnvironment) + newEnvironmentStr = dict( + (key, str(value)) + for (key, value) in self.environment.items() + ) + if oldEnvironmentStr != newEnvironmentStr: + self.dumpEnvironment(old=oldEnvironmentStr) + oldEnvironmentStr = newEnvironmentStr if self.environment[constants.BaseEnv.ERROR]: infos = self.environment[ @@ -457,7 +462,7 @@ for key in sorted(self.environment.keys()): if ( old is None or - self.environment[key] != old.get(key) + str(self.environment[key]) != str(old.get(key)) ): value = self.environment[key] if key in self.environment[ -- To view, visit http://gerrit.ovirt.org/23517 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I15969681d8fab57e326a7977a5ed0703d4e9fbd7 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
