Alon Bar-Lev has posted comments on this change. Change subject: core: dumpEnvironment str compare to old ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/23517/2/src/otopi/context.py File src/otopi/context.py: Line 224: self.registerDialog(dialog.DialogBase()) Line 225: self.registerServices(services.ServicesBase()) Line 226: self.registerPackager(packager.PackagerBase()) Line 227: self.registerCommand(command.CommandBase()) Line 228: self._oldEnvironmentStr = {} there should be no reason to store the environment in object context. we have the following logic checkpoint operation checkpoint this is constraint within block, moving this into object state is incorrect. Line 229: Line 230: def notify(self, event): Line 231: """Notify plugins. Line 232: -- To view, visit http://gerrit.ovirt.org/23517 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15969681d8fab57e326a7977a5ed0703d4e9fbd7 Gerrit-PatchSet: 2 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
