Alon Bar-Lev has posted comments on this change. Change subject: tools: Support snmp trap as a notification method. ......................................................................
Patch Set 18: (1 comment) http://gerrit.ovirt.org/#/c/22909/18/packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in File packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in: Line 149: # Line 150: # 3.) add a new snmp subscriber to all events using default definitions, overriding only the oid. Line 151: # SNMP_OID_DAVE=1.2.3.4 Line 152: # FILTER="${FILTER} -(SNMP:DAVE)" Line 153: FILTER= > Correct me if I'm wrong but I think what we agreed upon makes no sense: ple please do not submit a new patch until we end discussion. 1. we did not discuss adding this '-' operator. 2. we did not discuss a profile for email. 3. we discuss the prefix of snmp and smtp 4. we did not discuss grouping events please understand that you cannot just go ahead and modify user exposed information without reconsult. now, if you want to keep your changes: 1. please use include: exclude: prefix instead of '-' operator. 2. please remove the profile for email and use plain single format which is email address. 3. please use lower case consistent transport name as prefix (snmp:, smtp:). 4. for group of event we need a clear syntax, example: include:(event1, event2)[transport1, transport2] exclude:(event2)[transport1] or any syntax you suggest *BEFORE* implementation and we agree upon. thanks! Line 154: Line 155: #----------------------------------# Line 156: # Engine Monitoring Configuration: # Line 157: #----------------------------------# -- To view, visit http://gerrit.ovirt.org/22909 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0cd22d022ae535f45e046b09a2cbfadd837b465c Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
