Alon Bar-Lev has posted comments on this change. Change subject: tools: Support snmp trap as a notification method. ......................................................................
Patch Set 18: (1 comment) http://gerrit.ovirt.org/#/c/22909/18/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java: Line 126: if (subscriber.isSubscribed(event)) { Line 127: log.debug(sb.append("address:") Line 128: .append(subscriber.getMethodAddress()) Line 129: .append(" subscribed to event: ") Line 130: .append(event.getLogTypeName()).toString() > This perfectly readable builder execution in Java, I don't see anything unr yeah! I know, this is the problem with java programmers... they so used to their stuff so they are blind. all at the name of performance... which is java weakness at the first place. Line 131: ); Line 132: EventSender sender = notificationMethodsMapper.getEventSender(subscriber.getEventNotificationMethod()); Line 133: EventSenderResult sendResult; Line 134: try { -- To view, visit http://gerrit.ovirt.org/22909 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0cd22d022ae535f45e046b09a2cbfadd837b465c Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
