Martin Peřina has posted comments on this change. Change subject: tools: Fix command line args in engine-manage-domains ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/23842/1/backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomainsArguments.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomainsArguments.java: Line 205: if (!parsed.isEmpty()) { Line 206: if (parsed.containsKey(ARG_HELP)) { Line 207: // print help Line 208: argMap.put(ARG_HELP, null); Line 209: return; > it is a result... better throw than return in middle. Well, 'invalid action error' test is on line 185. This condition is about cases like: engine-manage-domains add --help But I didn't want to complicate help, so I always print full help even that in this case I could print only help for add action Line 210: } Line 211: Line 212: // config file can be entered for all actions Line 213: moveArgsValues(parsed, ARG_CONFIG_FILE); Line 221: checkRequiredArgsValue(ARG_DOMAIN, ARG_PROVIDER, ARG_USER, ARG_PASSWORD_FILE, Line 222: ARG_CHANGE_PASSWORD_URL); Line 223: Line 224: } else if (ACTION_EDIT.equals(action)) { Line 225: moveArgsValues(parsed, > I think that metadata programming is superior... OK, I will try to look at this Line 226: ARG_DOMAIN, ARG_PROVIDER, ARG_USER, ARG_PASSWORD_FILE, ARG_LDAP_SERVERS, Line 227: ARG_ADD_PERMISSIONS, ARG_CHANGE_PASSWORD_URL); Line 228: checkRequiredArgs(ARG_DOMAIN); Line 229: checkRequiredArgsValue(ARG_DOMAIN, ARG_PROVIDER, ARG_USER, ARG_PASSWORD_FILE, -- To view, visit http://gerrit.ovirt.org/23842 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1296958a54d8b802e0d6fb59f1f75cc608e75818 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
