Alon Bar-Lev has posted comments on this change. Change subject: tools: Fix command line args in engine-manage-domains ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/23842/1/backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomainsArguments.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomainsArguments.java: Line 205: if (!parsed.isEmpty()) { Line 206: if (parsed.containsKey(ARG_HELP)) { Line 207: // print help Line 208: argMap.put(ARG_HELP, null); Line 209: return; > Well, 'invalid action error' test is on line 185. so this can go with bellow, as if any mandatory argument is missing you can print the help. Line 210: } Line 211: Line 212: // config file can be entered for all actions Line 213: moveArgsValues(parsed, ARG_CONFIG_FILE); -- To view, visit http://gerrit.ovirt.org/23842 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1296958a54d8b802e0d6fb59f1f75cc608e75818 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
