Sergey Gotliv has uploaded a new change for review. Change subject: webadmin: Remove redundant super.validate() from NewDiskModel ......................................................................
webadmin: Remove redundant super.validate() from NewDiskModel NewDiskModel validate() contained 2 calls to the super.validate() when result of the first call is completely ignored. Change-Id: Id744a08dd74d1536218363f3d9f19cd13cc4c97b Signed-off-by: Sergey Gotliv <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewDiskModel.java 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/58/23958/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewDiskModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewDiskModel.java index 3fa7bbd..4a3f982 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewDiskModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewDiskModel.java @@ -210,8 +210,6 @@ @Override public boolean validate() { - super.validate(); - if ((Boolean) getIsAttachDisk().getEntity()) { if (isSelectionsEmpty(getInternalAttachableDisks()) && isSelectionsEmpty(getExternalAttachableDisks())) { getInvalidityReasons().add(CONSTANTS.noDisksSelected()); -- To view, visit http://gerrit.ovirt.org/23958 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id744a08dd74d1536218363f3d9f19cd13cc4c97b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
