Alon Bar-Lev has posted comments on this change.

Change subject: frontend: Console client page url retrieval
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/24003/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/DynamicMessages.java
File 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/DynamicMessages.java:

Line 322: 
Line 323:         return isAbsolute
Line 324:                  ? url
Line 325:                  : Window.Location.getProtocol() + "//" + 
Window.Location.getHost() + //$NON-NLS-1$
Line 326:                     "/" + 
BaseContextPathData.getInstance().getRelativePath() + url; //$NON-NLS-1$
no... this can be relative as well...

see: 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ReportInit.java
Line 327:     }
Line 328: 
Line 329:     /**
Line 330:      * Get the application documentation title using the {@code 
Dictionary} in the host page. With a fall back to the standard GWT


-- 
To view, visit http://gerrit.ovirt.org/24003
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8da4313e8fa6bf4a3f170750ab6fab0d21869ea
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to