Alexander Wels has posted comments on this change. Change subject: frontend: Console client page url retrieval ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/24003/3/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/DynamicMessages.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/DynamicMessages.java: Line 315: * @return The console client resources page url. Line 316: */ Line 317: public final String consoleClientResourcesUrl() { Line 318: String url = getString(DynamicMessageKey.CONSOLE_CLIENT_RESOURCES_URL); Line 319: boolean isAbsolute = url.contains("://"); //$NON-NLS-1$ isAbsolute is determined by if it has a scheme or not correct? Maybe use this instead? import com.google.gwt.safehtml.shared.UriUtils; boolean isAbsolute = UriUtils.extractScheme(url) != null; Line 320: Line 321: return isAbsolute Line 322: ? url Line 323: : "/" + BaseContextPathData.getInstance().getRelativePath() + url; //$NON-NLS-1$ -- To view, visit http://gerrit.ovirt.org/24003 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib8da4313e8fa6bf4a3f170750ab6fab0d21869ea Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
