Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: added upgrade path from legacy setup ......................................................................
Patch Set 21: (2 comments) http://gerrit.ovirt.org/#/c/23617/21/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py: Line 561: _('Could not regenerate build configuration') Line 562: ) Line 563: finally: Line 564: os.umask(myumask) Line 565: os.chmod( this should not be in finally, as if there is exception it may not exist Line 566: ( Line 567: oreportscons.FileLocations. Line 568: OVIRT_ENGINE_REPORTS_FOOMATIC_CONFIG Line 569: ), Line 904: ), Line 905: ), Line 906: ): Line 907: if os.path.exists(d): Line 908: self.logger.debug(_('Removing folder: %s'), d) in debug you do not need to use gettext... remove the _() Line 909: shutil.rmtree(d) Line 910: Line 911: @plugin.event( Line 912: stage=plugin.Stages.STAGE_CLEANUP, -- To view, visit http://gerrit.ovirt.org/23617 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39a384db8bc93dd0a5c0a0fe43e2c59e8e474a97 Gerrit-PatchSet: 21 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
