Yaniv Dary has posted comments on this change. Change subject: packaging: setup: added upgrade path from legacy setup ......................................................................
Patch Set 13: (4 comments) http://gerrit.ovirt.org/#/c/23617/13/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py: Line 517: os.path.exists( Line 518: oreportscons.FileLocations.LEGACY_OVIRT_ENGINE_REPORTS_JASPER_WAR, Line 519: ) Line 520: ): Line 521: > no need for this space Done Line 522: shutil.copyfile( Line 523: oreportscons.FileLocations.LEGACY_OVIRT_ENGINE_REPORTS_JASPER_WAR, Line 524: self._quartzprops, Line 525: ) Line 523: oreportscons.FileLocations.LEGACY_OVIRT_ENGINE_REPORTS_JASPER_WAR, Line 524: self._quartzprops, Line 525: ) Line 526: Line 527: self.logger.info(_('Regenerating build conf files')) > this should be prefixed with jasper or something... like other messages we Done Line 528: Line 529: try: Line 530: myumask = os.umask(0o022) Line 531: Line 531: Line 532: rc, stdout, stderr = self.execute( Line 533: args=( Line 534: './js-ant', Line 535: '-DmasterPropsSource=%s' % config, > remider... this config should be created... Done Line 536: 'gen-config', Line 537: ), Line 538: cwd=os.path.join( Line 539: self.environment[ Line 554: else: Line 555: shutil.copyfile( Line 556: oreportscons.FileLocations.OVIRT_ENGINE_REPORTS_JASPER_QUARTZ, Line 557: self._quartzprops, Line 558: ) > now... I know I stretch you... but usually shorter trivial block should be Done Line 559: Line 560: self._jobs = self._exportJs( Line 561: what='jobs', Line 562: args=( -- To view, visit http://gerrit.ovirt.org/23617 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39a384db8bc93dd0a5c0a0fe43e2c59e8e474a97 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
