Tal Nisan has posted comments on this change. Change subject: webadmin: Grey out the remove button for template disks in storage disks tab ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/24244/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDiskListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDiskListModel.java: Line 124: boolean isImageLocked = disk.getImageStatus() == ImageStatus.LOCKED; Line 125: Line 126: boolean isTemplateDisk = disk.getVmEntityType() != null && disk.getVmEntityType().isTemplateType(); Line 127: Line 128: if (isImageLocked || isTemplateDisk) { > it shouldn't be grayed out for template disks. a template disk can be remov Well, we can bring the relevant data, but they thing is that it has to match the behavior in the disks main tab, it's either greyed out in both or active in both, can't have different behaviors Line 129: return false; Line 130: } Line 131: } Line 132: -- To view, visit http://gerrit.ovirt.org/24244 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54ddae6e950318d95a3f87e540b3d8d210abcd60 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
