Daniel Erez has posted comments on this change. Change subject: webadmin: Grey out the remove button for template disks in storage disks tab ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/24244/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDiskListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDiskListModel.java: Line 124: boolean isImageLocked = disk.getImageStatus() == ImageStatus.LOCKED; Line 125: Line 126: boolean isTemplateDisk = disk.getVmEntityType() != null && disk.getVmEntityType().isTemplateType(); Line 127: Line 128: if (isImageLocked || isTemplateDisk) { > Well, we can bring the relevant data, but they thing is that it has to matc Why not? Te purpose of disks sub-tab (under storage) is to give the admin information of the selected domain content and to allow freeing data. in regards to templates disks, removing is applicable only if we have a context of a storage domains. I.e. template disks can be removed from storage->disks sub-tab or templates->storage sub-tab. Try to check if disk.getStorageIds can be larger than 1 in storage->disks sub-tab - so it could be used as an indication. If not, having a cando message is good enough. Line 129: return false; Line 130: } Line 131: } Line 132: -- To view, visit http://gerrit.ovirt.org/24244 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54ddae6e950318d95a3f87e540b3d8d210abcd60 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
