Omer Frenkel has posted comments on this change. Change subject: UI: add indication the VMInit root password is set ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/23988/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java: Line 305: // since we are not always returning the password in Line 306: // updateVmInitFromDB() Line 307: // method (we don't want to display it in the UI/API) we Line 308: // don't want to override Line 309: // the password if the flag is on if the flag is on, doesnt it mean the user entered a different password and want to update to it? Line 310: vm.getVmInit().setRootPassword(oldVmInit.getRootPassword()); Line 311: } Line 312: db.update(vm.getVmInit()); Line 313: } http://gerrit.ovirt.org/#/c/23988/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmInit.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmInit.java: Line 19: private List<VmInitNetwork> networks; Line 20: Line 21: private String winKey; Line 22: private String rootPassword; Line 23: private boolean passwordSet; maybe rename it to passwordExist Line 24: private String customScript; Line 25: Line 26: public VmInit() { Line 27: } -- To view, visit http://gerrit.ovirt.org/23988 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iedfea8520e885c948772dd0d1b612296aeced895 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
