Omer Frenkel has posted comments on this change. Change subject: UI: add indication the VMInit root password is set ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/23988/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java: Line 287: public static void updateVmInitFromDB(VmBase vm, boolean secure) { Line 288: VmInitDAO db = DbFacade.getInstance().getVmInitDao(); Line 289: vm.setVmInit(db.get(vm.getId())); Line 290: if (secure && vm.getVmInit() != null) { Line 291: vm.getVmInit().setPasswordAlreadyStored(!StringUtils.isEmpty(vm.getVmInit().getRootPassword())); i guess you should update this field always (even if secure is false) Line 292: vm.getVmInit().setRootPassword(null); Line 293: } Line 294: } Line 295: -- To view, visit http://gerrit.ovirt.org/23988 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iedfea8520e885c948772dd0d1b612296aeced895 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
