Arik Hadas has posted comments on this change. Change subject: core: refactor failure to run vm flow - part 5 ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/24162/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java: Line 240: endExecutionMonitoring(); Line 241: } Line 242: } Line 243: finally { Line 244: freeLock(); > is it ok to free lock here for run vm coomands? this didnt exist before yep. that's ok because in run vm commands we release the lock at the end of the EXECUTE phase so when we get here the command's lock is null and freeLock knows how to handle the case where the command's lock is null Line 245: } Line 246: } Line 247: Line 248: protected void endExecutionMonitoring() { -- To view, visit http://gerrit.ovirt.org/24162 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib02c6a37333785845e6e8246b1a8f4c326e9049d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
