Omer Frenkel has submitted this change and it was merged. Change subject: core: refactor failure to run vm flow - part 5 ......................................................................
core: refactor failure to run vm flow - part 5 This patch is a preliminary step before removing MigrateVmCommand#reportCompleted: - Move the call to freeLock to RunVmCommandBase#reportCompleted - Extract the code that actually ends the command's monitoring job/step to separate method. RunVmCommand & RunVmOnceCommand used to override RunVmCommandBase#reportCompleted just to change the way the job/step is ended, so they are now override the new method instead. Change-Id: Ib02c6a37333785845e6e8246b1a8f4c326e9049d Signed-off-by: Arik Hadas <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java 4 files changed, 29 insertions(+), 23 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/24162 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib02c6a37333785845e6e8246b1a8f4c326e9049d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
