Allon Mureinik has posted comments on this change. Change subject: engine : creating storage connection with empty port, port is set to 0 ......................................................................
Patch Set 1: (2 comments) Daniel - please review. Cheryn - please take a look at backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties Thanks! http://gerrit.ovirt.org/#/c/24402/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommand.java: Line 89: } Line 90: Line 91: if (paramConnection.getstorage_type() == StorageType.ISCSI Line 92: && (StringUtils.isEmpty(paramConnection.getport()) Line 93: || Integer.parseInt(paramConnection.getport()) <= 0)) { What happens if the port does not represent an integer? e.g., if someone passed port = abc ? Line 94: return failCanDoAction(VdcBllMessages.VALIDATION_STORAGE_CONNECTION_INVALID_PORT); Line 95: } Line 96: Line 97: if (checkIsConnectionFieldEmpty(paramConnection)) { http://gerrit.ovirt.org/#/c/24402/1/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties: Line 724: MISSING_DIRECTORY_ELEMENT_ID=User/group ID cannot be empty. Line 725: NETWORK_ILEGAL_NETWORK_NAME=Network name must be 1-15 long and can contain only 'A-Z', 'a-z', '0-9', '_' characters Line 726: STORAGE_OPERATION_FAILED_SPM_NETWORK_PROBLEMS=Storage related operations can't be performed while the Storage Pool Manager is down.\nPlease make sure the Storage Pool Manager is up and running, and check network connectivity. Line 727: VALIDATION_STORAGE_CONNECTION_INVALID=Mount path is illegal, please use [IP:/path or FQDN:/path] convention. Line 728: VALIDATION_STORAGE_CONNECTION_INVALID_PORT=Invalid value for port. Port should be greater than 0. IMHO - "... should be an integer greater than 0" Line 729: VALIDATION_STORAGE_CONNECTION_EMPTY_VFSTYPE=VFS type cannot be empty. Line 730: VALIDATION_STORAGE_CONNECTION_EMPTY_IQN=Target details cannot be empty. Line 731: VALIDATION_STORAGE_CONNECTION_EMPTY_CONNECTION=${fieldName} field cannot be empty. Line 732: VALIDATION_STORAGE_CONNECTION_NFS_RETRANS=NFS Retransmissions should be between 0 and 32767 -- To view, visit http://gerrit.ovirt.org/24402 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief68a9b65946d88e3eace6f21fc887ea373725b1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Cheryn Tan <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
