Allon Mureinik has posted comments on this change. Change subject: engine: Adding ApplicationMode to vdc_options ......................................................................
Patch Set 4: I would prefer that you didn't submit this ConfigurationValues is supposed to be subset of ConfigValues - it cannot be used (i.e., given as a parameter to GetConfigurationValueQuery) if it is not. Please move the extra value you add to ConfigValues in the subsequent patch to this patch. -- To view, visit http://gerrit.ovirt.org/4383 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2abb71bde26f16c7d64fd122825fa5ee210d79c9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
