Kanagaraj M has posted comments on this change. Change subject: engine: Adding ApplicationMode to vdc_options ......................................................................
Patch Set 6: No score Every mode is represented by a bit. For now 3 may be sufficient but in future there might be a new mode ex. QUANTOM_ONLY(value-4) binary equivalent 0000 0100. At that time we might need the default value as 7 (3 right most bits set). Just to avoid changing this value in future, it is been set as 255 (binary - 1111 1111) ALL_MODES. This doesn't require a change in future even if we add 6 more modes. -- To view, visit http://gerrit.ovirt.org/4383 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2abb71bde26f16c7d64fd122825fa5ee210d79c9 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
