Itamar Heim has posted comments on this change. Change subject: core: user level queries - filtered entities ......................................................................
Patch Set 2: (2 inline comments) .................................................... Commit Message Line 30: horizontal one. 1. are you sure db layer is the right place for this change, rather than entity behaviour at java layer? 2. you chose which fields to mask. this is about security, you should use white-list approach, and specify which fields should be exposed, rather than which should not. Line 34: user portal.) don't think user portal. think rest api -- To view, visit http://gerrit.ovirt.org/4469 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If68b290aaacc0eea5d117ef64536cbf94d195cee Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
