Allon Mureinik has posted comments on this change. Change subject: core: user level queries - filtered entities ......................................................................
Patch Set 5: is the field list is static, why do we need dynamic SQL? Why not create another view, "user_vds"? it will be a pain to maintain, but I don't see how adding another field to =such a view is conceptually different from adding another column to the whitelist? Moreover - if we forget to add a column, tests will break, and we'll know we forgot something. Forgetting to add a column to the white list will cause the function to return null, which will be much harder to catch. -- To view, visit http://gerrit.ovirt.org/4469 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If68b290aaacc0eea5d117ef64536cbf94d195cee Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
