Shireesh Anjal has posted comments on this change.
Change subject: engine: Add ID fields to gluster brick and option
......................................................................
Patch Set 2: (3 inline comments)
responses inline.
....................................................
File backend/manager/dbscripts/upgrade/03_01_1090_gluster_brick_option_id.sql
Line 11: ALTER TABLE gluster_volume_options ADD CONSTRAINT
IDX_gluster_volume_options_volume_id_option_key UNIQUE(volume_id, option_key);
I think that no one apart from the gluster team is working on gluster related
features, and hence skipped the "data migration" part. Will add it if you
insist :)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterBrickEntity.java
Line 26: private Guid volumeId;
I think I need to correct this. volumeId, serverId, and brickDirectory are
required in "CreateEntity" context, whereas id is required in UpdateEntity and
RemoveEntity contexts. Will correct and send another patch-set.
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterBrickDaoDbFacadeImpl.java
Line 29: getCustomMapSqlParameterSource().addValue("id",
brickId.getUuid()));
It might work with Guid itself, but I thought it makes sense to pass java UUID
as it would be the appropriate data type matching with postgres' UUID. I will
remove the call to getUuid() if you are particular about it.
--
To view, visit http://gerrit.ovirt.org/4431
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2698e1686b18a03111f94145d0eb961be85d0131
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
