Omer Frenkel has posted comments on this change. Change subject: engine: Add ID fields to gluster brick and option ......................................................................
Patch Set 7: Looks good to me, approved (1 inline comment) .................................................... File backend/manager/dbscripts/upgrade/03_01_1090_gluster_brick_option_id.sql Line 3: UPDATE gluster_volume_bricks set id = uuid_generate_v1(); but wouldn't it cause all entries to have the same id? (im not sure about this) -- To view, visit http://gerrit.ovirt.org/4431 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2698e1686b18a03111f94145d0eb961be85d0131 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
