Alexander Wels has uploaded a new change for review. Change subject: webadmin: Host network interface subtab data ......................................................................
webadmin: Host network interface subtab data - Fixed issue where when pressing refresh on the main tab grid, and the network interface subtab was open the data for the subtab would disappear. Change-Id: Ibb539f95353992f589d251629be76f02a0196d18 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1066827 Signed-off-by: Alexander Wels <[email protected]> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/refresh/AbstractRefreshManager.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostInterfacePresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostInterfaceView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/HostInterfaceForm.java 4 files changed, 2 insertions(+), 28 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/52/24852/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/refresh/AbstractRefreshManager.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/refresh/AbstractRefreshManager.java index b466424..b22a909 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/refresh/AbstractRefreshManager.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/refresh/AbstractRefreshManager.java @@ -18,14 +18,12 @@ import com.google.gwt.event.logical.shared.ValueChangeEvent; import com.google.gwt.event.logical.shared.ValueChangeHandler; import com.google.gwt.event.shared.EventBus; -import com.google.gwt.event.shared.GwtEvent; import com.google.gwt.event.shared.HandlerRegistration; -import com.google.gwt.event.shared.HasHandlers; /** * Provides refresh rate management for a {@link GridController}. */ -public abstract class AbstractRefreshManager<T extends BaseRefreshPanel> implements HasHandlers { +public abstract class AbstractRefreshManager<T extends BaseRefreshPanel> { /** * Callback triggered when the user clicks the refresh button. @@ -148,7 +146,6 @@ if (manualRefreshCallback != null) { manualRefreshCallback.onManualRefresh(); } - ManualRefreshEvent.fire(AbstractRefreshManager.this); controller.refresh(); } }); @@ -201,10 +198,5 @@ public void setManualRefreshCallback(ManualRefreshCallback manualRefreshCallback) { this.manualRefreshCallback = manualRefreshCallback; - } - - @Override - public void fireEvent(GwtEvent<?> event) { - eventBus.fireEvent(event); } } diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostInterfacePresenter.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostInterfacePresenter.java index 1ac529b..52926d1 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostInterfacePresenter.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostInterfacePresenter.java @@ -4,8 +4,6 @@ import org.ovirt.engine.ui.common.place.PlaceRequestFactory; import org.ovirt.engine.ui.common.presenter.AbstractSubTabPresenter; import org.ovirt.engine.ui.common.uicommon.model.SearchableDetailModelProvider; -import org.ovirt.engine.ui.common.widget.refresh.ManualRefreshEvent; -import org.ovirt.engine.ui.common.widget.refresh.ManualRefreshEvent.ManualRefreshHandler; import org.ovirt.engine.ui.common.widget.tab.ModelBoundTabData; import org.ovirt.engine.ui.uicommonweb.models.hosts.HostInterfaceLineModel; import org.ovirt.engine.ui.uicommonweb.models.hosts.HostInterfaceListModel; @@ -36,7 +34,6 @@ } public interface ViewDef extends AbstractSubTabPresenter.ViewDef<VDS> { - void removeContent(); void setRefreshButtonVisibility(boolean visible); } @@ -62,14 +59,6 @@ @Override protected void onBind() { super.onBind(); - registerHandler(getEventBus().addHandler(ManualRefreshEvent.getType(), new ManualRefreshHandler() { - @Override - public void onManualRefresh(ManualRefreshEvent event) { - if (SubTabHostInterfacePresenter.this.isVisible()) { - getView().removeContent(); - } - } - })); getModelProvider().getModel().getTimer().addValueChangeHandler(new ValueChangeHandler<Integer>() { @Override public void onValueChange(ValueChangeEvent<Integer> event) { diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostInterfaceView.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostInterfaceView.java index 0d2ef93..d1ac665 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostInterfaceView.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostInterfaceView.java @@ -131,13 +131,6 @@ } @Override - public void removeContent() { - if (hostInterfaceForm != null) { - hostInterfaceForm.setVisible(false); - } - } - - @Override public void setMainTabSelectedItem(VDS selectedItem) { // TODO(vszocs) possible performance optimization: don't create HostInterfaceForm upon each selection hostInterfaceForm = new HostInterfaceForm(getDetailModel()); diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/HostInterfaceForm.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/HostInterfaceForm.java index 8ef2e14..f363231 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/HostInterfaceForm.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/HostInterfaceForm.java @@ -82,7 +82,7 @@ } void showModels(List<HostInterfaceLineModel> interfaceLineModels) { - this.setVisible(true); +// this.setVisible(true); grid.resizeRows(interfaceLineModels.size()); int row = 0; -- To view, visit http://gerrit.ovirt.org/24852 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibb539f95353992f589d251629be76f02a0196d18 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
