Lior Vernia has posted comments on this change. Change subject: webadmin: Host network interface subtab data ......................................................................
Patch Set 1: (3 comments) Could the ManualRefresh class possibly be removed now as well? http://gerrit.ovirt.org/#/c/24852/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/refresh/AbstractRefreshManager.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/refresh/AbstractRefreshManager.java: Line 59 Line 60 Line 61 Line 62 Line 63 This member can be removed now, can't it? Probably for the constructor as well (not sure there was ever a reason for it there). http://gerrit.ovirt.org/#/c/24852/1/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostInterfaceView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostInterfaceView.java: Line 45: } Line 46: Line 47: @WithElementId Line 48: final SimpleActionTable<HostInterfaceLineModel> table; Line 49: private final VerticalPanel contentPanel; Initialization to null here isn't necessary (this was added in the original patch). Line 50: HostInterfaceForm hostInterfaceForm = null; Line 51: Line 52: @Inject Line 53: public SubTabHostInterfaceView(SearchableDetailModelProvider<HostInterfaceLineModel, HostListModel, HostInterfaceListModel> modelProvider, http://gerrit.ovirt.org/#/c/24852/1/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/HostInterfaceForm.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/HostInterfaceForm.java: Line 81: return panel; Line 82: } Line 83: Line 84: void showModels(List<HostInterfaceLineModel> interfaceLineModels) { Line 85: // this.setVisible(true); Reason for commenting out instead of removing? Line 86: grid.resizeRows(interfaceLineModels.size()); Line 87: int row = 0; Line 88: Line 89: for (HostInterfaceLineModel lineModel : interfaceLineModels) { -- To view, visit http://gerrit.ovirt.org/24852 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb539f95353992f589d251629be76f02a0196d18 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
