Alon Bar-Lev has posted comments on this change. Change subject: 8. [WIP] core: Introducing Extension manager ......................................................................
Patch Set 22: (2 comments) http://gerrit.ovirt.org/#/c/24365/22/backend/manager/modules/extension-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionManager.java File backend/manager/modules/extension-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionManager.java: Line 215: private void activate() { Line 216: for (ExtensionEntry entry : loadedEntries.values()) { Line 217: if (entry.enabled) { Line 218: activatedEntries.put(entry.getName(), entry); Line 219: createExtension(entry, loadModule(entry.getConfig().getProperty(MODULE))); > I do not like createExtension modify the entry... I think it should be: well, I found what bothering me... this function should be plain generic module class fetcher, so I expect: entry.extension = acquireClass( Extension.class, entry.getConfig().getProperty(MODULE), entry.getConfig().getProperty(CLASS) ) this way this acquireClass can be unrelated to our cause... much cleaner. Line 220: List<ExtensionEntry> entries = providesEntries.get(entry.getProvides()); Line 221: if (entries == null) { Line 222: entries = new ArrayList<>(); Line 223: providesEntries.put(entry.getProvides(), entries); Line 221: if (entries == null) { Line 222: entries = new ArrayList<>(); Line 223: providesEntries.put(entry.getProvides(), entries); Line 224: } Line 225: entries.add(entry); can you please put somewhere at utilities the ability to add entry to a list within map? you write this code over and over... maybe there is something in commons? or our own? I expect: Utils.addMapListEntry(providesEntries, entry.getProvides(), entry) Line 226: } Line 227: } Line 228: } -- To view, visit http://gerrit.ovirt.org/24365 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I182904177ec088e62b35bde870ec79725fabc4e4 Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
