Yair Zaslavsky has posted comments on this change. Change subject: 8. [WIP] core: Introducing Extension manager ......................................................................
Patch Set 22: (1 comment) http://gerrit.ovirt.org/#/c/24365/22/backend/manager/modules/extension-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionManager.java File backend/manager/modules/extension-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionManager.java: Line 75: public Map<ExtensionProperties, Object> getContext() { Line 76: return context; Line 77: } Line 78: Line 79: public Extension getExtension() { > Done Actually , cannot be private, see AutthenticationProfileRepository.createProfiles - I need access to the extension in order to create profile. any other suggestions? Line 80: return extension; Line 81: } Line 82: Line 83: public void setExtension(Extension extension) { -- To view, visit http://gerrit.ovirt.org/24365 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I182904177ec088e62b35bde870ec79725fabc4e4 Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
